Skip to content

First draft of idmapping.py #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ialarmedalien wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

First draft of idmapping.py #72

ialarmedalien wants to merge 6 commits into from

Conversation

@ialarmedalien
Copy link
Collaborator

@ialarmedalien ialarmedalien commented Jan 23, 2026

Description of PR purpose/changes

  • Please include a summary of the change and which issue is fixed.
  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run Ruff format to format my code
  • I have run Ruff check and fixed any errors that it uncovered
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

@codecov
Copy link

codecov bot commented Jan 26, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.53631% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.00%. Comparing base (f887ab3) to head (9845503).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdm_data_loader_utils/utils/minio.py 30.23% 30 Missing ⚠️
...cdm_data_loader_utils/parsers/uniprot/idmapping.py 85.71% 6 Missing ⚠️
.../cdm_data_loader_utils/parsers/uniprot/metalink.py 92.15% 4 Missing ⚠️
.../cdm_data_loader_utils/parsers/uniprot/relnotes.py 95.34% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #72       +/-   ##
============================================
- Coverage    51.21%   13.00%   -38.21%     
============================================
  Files           59       60        +1     
  Lines         3050     3045        -5     
============================================
- Hits          1562      396     -1166     
- Misses        1488     2649     +1161
Files with missing lines Coverage Δ
src/cdm_data_loader_utils/parsers/uniprotkb.py 0.00% <ø> (ø)
.../cdm_data_loader_utils/parsers/uniprot/relnotes.py 95.34% <95.34%> (ø)
.../cdm_data_loader_utils/parsers/uniprot/metalink.py 92.15% <92.15%> (ø)
...cdm_data_loader_utils/parsers/uniprot/idmapping.py 85.71% <85.71%> (ø)
src/cdm_data_loader_utils/utils/minio.py 30.23% <30.23%> (ø)

... and 22 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54dbea...9845503. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ialarmedalien